Skip to content

feat: Add positioning: "relative|absolute" to View Hierarchy#150

Merged
Lms24 merged 2 commits intogetsentry:mainfrom
timfish:view-hierarchy-positioning
Feb 4, 2026
Merged

feat: Add positioning: "relative|absolute" to View Hierarchy#150
Lms24 merged 2 commits intogetsentry:mainfrom
timfish:view-hierarchy-positioning

Conversation

@timfish
Copy link
Contributor

@timfish timfish commented Feb 2, 2026

Currently relative/absolute positioning for View Hierarchy wireframes is always relative unless the platform matches a predefined list:
https://github.com/getsentry/sentry/blob/e07092c0583191c0a85e3f70a8d918920a569870/static/app/components/events/viewHierarchy/wireframe.tsx#L51-L54

      getHierarchyDimensions(
        hierarchy,
        ['flutter', 'dart-flutter'].includes(platform ?? '')
      ),

SDKs should be able to override this without having to update this predefined list in Sentry.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my end! I asked the mobile team for their input as well

@Lms24 Lms24 requested a review from markushi February 3, 2026 17:04
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lms24 Lms24 merged commit f9fc964 into getsentry:main Feb 4, 2026
3 checks passed
* `windows`: contains all visible windows, on mobile it's typically just one or two (e.g. if a dialog is open)
* `type`: The fully qualified widget class name, this name may be obfuscated on certain platforms (e.g. Android release builds with proguard enabled)
* `children` nests all child UI widgets, which then builds up the whole UI tree
* `positioning`: indicates how the element is positioned in relation to its parent. If not supplied, defaults to platform default.
Copy link
Member

@philprime philprime Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we define the platform default? Can we add a link here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per, getsentry/sentry#107507, relative is the default and there is a small list of platforms overriding it.

@timfish timfish deleted the view-hierarchy-positioning branch February 5, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants